Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Filter blocks before loading it. Sort advertise labels; Added sharding e2e test. #1669

Merged
merged 3 commits into from
Oct 22, 2019

Conversation

bwplotka
Copy link
Member

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Fixes: #1664

Signed-off-by: Bartek Plotka [email protected]

@jojohappy
Copy link
Member

test failed ):

Signed-off-by: Bartek Plotka <[email protected]>
Copy link
Contributor

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from a Go perspective mostly :)

@brancz
Copy link
Member

brancz commented Oct 22, 2019

It's not super clear why CI failed, any ideas?

@bwplotka
Copy link
Member Author

Yea, I am busy with other things, but it looks like

}); err != nil && errors.Cause(err) != context.Canceled {
			t.Fatal(err)
		}

our errors.Cause does not really find proper cause. The returned error indeed is canceled overall, but probably some wrapping masks it.

Signed-off-by: Bartek Plotka <[email protected]>
@bwplotka bwplotka merged commit 64af185 into master Oct 22, 2019
@bwplotka bwplotka deleted the store-relabel branch October 22, 2019 15:22
GiedriusS pushed a commit that referenced this pull request Oct 28, 2019
…sharding e2e test. (#1669)

* store: Filter blocks before loading it. Sort advertise labels; Added sharding e2e test.

Fixes: #1664

Signed-off-by: Bartek Plotka <[email protected]>

* Trying to speed up tests a bit.

Signed-off-by: Bartek Plotka <[email protected]>

* Fixed tests.

Signed-off-by: Bartek Plotka <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thanos store sharding memory issue
4 participants